Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aplx2 osu! keyboard #8847

Merged
merged 40 commits into from
Apr 27, 2020
Merged

Aplx2 osu! keyboard #8847

merged 40 commits into from
Apr 27, 2020

Conversation

Aplyard
Copy link
Contributor

@Aplyard Aplyard commented Apr 18, 2020 •
edited
Loading

A simple 2% keyboard for osu!

Description

Added a 2% Keyboard

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).
    test

Aplyard and others added 30 commits April 6, 2020 00:59
@Aplyard
Create test.txt
1c5f59c
@Aplyard
aplx6
a83104f
@Aplyard
Merge branch 'master' of https://github.com/Aplyard/qmk_firmware
41c1b6c
@Aplyard
Delete test.txt
bf988d9
@Aplyard
fff
12dce9b
@Aplyard
Delete ffff
2cff153
@Aplyard
test compile
c2e36ba
@Aplyard
Create README.md
4676149
@Aplyard
edited
79b2bb2
@Aplyard
requests
e34ccd7
@Aplyard @noroadsleft
Update keyboards/aplx6/README.md
6399013 
Co-Authored-By: James Young <[email protected]>
@Aplyard @noroadsleft
Update keyboards/aplx6/README.md
ecdc1e7 
Co-Authored-By: James Young <[email protected]>
@Aplyard @noroadsleft
Update keyboards/aplx6/README.md
00ccf14 
Co-Authored-By: James Young <[email protected]>
@Aplyard @noroadsleft
Update keyboards/aplx6/README.md
5f7e3f5 
Co-Authored-By: James Young <[email protected]>
@Aplyard @noroadsleft
Update keyboards/aplx6/README.md
72c3f1c 
Co-Authored-By: James Young <[email protected]>
@Aplyard @noroadsleft
Update keyboards/aplx6/README.md
29878d0 
Co-Authored-By: James Young <[email protected]>
@Aplyard @noroadsleft
Update keyboards/aplx6/README.md
b6786f2 
Co-Authored-By: James Young <[email protected]>
@Aplyard @noroadsleft
Update keyboards/aplx6/rules.mk
f61543e 
Co-Authored-By: James Young <[email protected]>
@Aplyard @noroadsleft
Update keyboards/aplx6/rules.mk
d713935 
Co-Authored-By: James Young <[email protected]>
@Aplyard @noroadsleft
Update keyboards/aplx6/README.md
7381233 
Co-Authored-By: James Young <[email protected]>
@Aplyard @noroadsleft
Update keyboards/aplx6/README.md
26594d8 
Co-Authored-By: James Young <[email protected]>
@Aplyard @noroadsleft
Update keyboards/aplx6/README.md
86b3989 
Co-Authored-By: James Young <[email protected]>
@Aplyard
pins update
05bea6b
@Aplyard
Merge branch 'master' of https://github.com/Aplyard/qmk_firmware
c75540f
@Aplyard
update
51cee7f
@Aplyard
update pins
94e34cf
@Aplyard @noroadsleft
Update keyboards/aplx6/README.md
b5396e8 
Co-Authored-By: James Young <[email protected]>
@Aplyard @noroadsleft
Update keyboards/aplx6/README.md
1ebb455 
Co-Authored-By: James Young <[email protected]>
@Aplyard
initial commit
0e41e9d
@Aplyard
Update aplx2.h
e7da4e0
zvecr
zvecr approved these changes Apr 20, 2020
View reviewed changes
Copy link
Member

@zvecr zvecr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UNICODE_ENABLE = yes being enabled by default could be changed, otherwise LGTM

@zvecr zvecr requested review from fauxpark and a team April 20, 2020 09:40
@Aplyard
Copy link
Contributor Author

Aplyard commented Apr 20, 2020

I left it enabled in case someone else wanted to use a specific type of symbol. No problem switching it off if you find it necessary.

drashna
drashna requested changes Apr 23, 2020
View reviewed changes
keyboards/handwired/aplx2/README.md Outdated Show resolved Hide resolved
keyboards/handwired/aplx2/README.md Outdated Show resolved Hide resolved
keyboards/handwired/aplx2/rules.mk Outdated Show resolved Hide resolved
@zvecr zvecr requested a review from drashna April 24, 2020 16:44
noroadsleft
noroadsleft requested changes Apr 25, 2020
View reviewed changes
keyboards/handwired/aplx2/README.md Outdated Show resolved Hide resolved
@noroadsleft noroadsleft merged commit cfdd105 into qmk:master Apr 27, 2020
@noroadsleft
Copy link
Member

Thanks!

brandonschlack pushed a commit to brandonschlack/qmk_firmware that referenced this pull request Apr 27, 2020
@Aplyard @brandonschlack
[Keyboard] Aplx2 osu! keyboard (qmk#8847)
3bd347a 
* Create test.txt

* aplx6

* Delete test.txt

* fff

* Delete ffff

* test compile

* Create README.md

* edited

* requests

* Update keyboards/aplx6/README.md

* Update keyboards/aplx6/README.md

* Update keyboards/aplx6/README.md

* Update keyboards/aplx6/README.md

* Update keyboards/aplx6/README.md

* Update keyboards/aplx6/README.md

* Update keyboards/aplx6/README.md

* Update keyboards/aplx6/rules.mk

* Update keyboards/aplx6/rules.mk

* Update keyboards/aplx6/README.md

* Update keyboards/aplx6/README.md

* Update keyboards/aplx6/README.md

* pins update

* update

* update pins

* Update keyboards/aplx6/README.md

* Update keyboards/aplx6/README.md

* initial commit

* Update aplx2.h

* Update keyboards/aplx2/README.md

* Update keyboards/aplx6/README.md

* Update keyboards/aplx6/README.md

* Update keyboards/aplx2/README.md

* folder change

* Update keyboards/handwired/aplx2/README.md

* Update keyboards/handwired/aplx2/README.md

* latest suggestion

* Update keyboards/handwired/aplx2/README.md
violet-fish pushed a commit to violet-fish/qmk_firmware that referenced this pull request May 3, 2020
@Aplyard @violet-fish
[Keyboard] Aplx2 osu! keyboard (qmk#8847)
f2ab1c8 
* Create test.txt

* aplx6

* Delete test.txt

* fff

* Delete ffff

* test compile

* Create README.md

* edited

* requests

* Update keyboards/aplx6/README.md

* Update keyboards/aplx6/README.md

* Update keyboards/aplx6/README.md

* Update keyboards/aplx6/README.md

* Update keyboards/aplx6/README.md

* Update keyboards/aplx6/README.md

* Update keyboards/aplx6/README.md

* Update keyboards/aplx6/rules.mk

* Update keyboards/aplx6/rules.mk

* Update keyboards/aplx6/README.md

* Update keyboards/aplx6/README.md

* Update keyboards/aplx6/README.md

* pins update

* update

* update pins

* Update keyboards/aplx6/README.md

* Update keyboards/aplx6/README.md

* initial commit

* Update aplx2.h

* Update keyboards/aplx2/README.md

* Update keyboards/aplx6/README.md

* Update keyboards/aplx6/README.md

* Update keyboards/aplx2/README.md

* folder change

* Update keyboards/handwired/aplx2/README.md

* Update keyboards/handwired/aplx2/README.md

* latest suggestion

* Update keyboards/handwired/aplx2/README.md
bitherder pushed a commit to bitherder/qmk_firmware that referenced this pull request May 15, 2020
@Aplyard @lorenzoernesto
[Keyboard] Aplx2 osu! keyboard (qmk#8847)
6800fb0 
* Create test.txt

* aplx6

* Delete test.txt

* fff

* Delete ffff

* test compile

* Create README.md

* edited

* requests

* Update keyboards/aplx6/README.md

* Update keyboards/aplx6/README.md

* Update keyboards/aplx6/README.md

* Update keyboards/aplx6/README.md

* Update keyboards/aplx6/README.md

* Update keyboards/aplx6/README.md

* Update keyboards/aplx6/README.md

* Update keyboards/aplx6/rules.mk

* Update keyboards/aplx6/rules.mk

* Update keyboards/aplx6/README.md

* Update keyboards/aplx6/README.md

* Update keyboards/aplx6/README.md

* pins update

* update

* update pins

* Update keyboards/aplx6/README.md

* Update keyboards/aplx6/README.md

* initial commit

* Update aplx2.h

* Update keyboards/aplx2/README.md

* Update keyboards/aplx6/README.md

* Update keyboards/aplx6/README.md

* Update keyboards/aplx2/README.md

* folder change

* Update keyboards/handwired/aplx2/README.md

* Update keyboards/handwired/aplx2/README.md

* latest suggestion

* Update keyboards/handwired/aplx2/README.md
sowbug pushed a commit to sowbug/qmk_firmware that referenced this pull request May 24, 2020
@Aplyard @sowbug
[Keyboard] Aplx2 osu! keyboard (qmk#8847)
ca38a39 
* Create test.txt

* aplx6

* Delete test.txt

* fff

* Delete ffff

* test compile

* Create README.md

* edited

* requests

* Update keyboards/aplx6/README.md

* Update keyboards/aplx6/README.md

* Update keyboards/aplx6/README.md

* Update keyboards/aplx6/README.md

* Update keyboards/aplx6/README.md

* Update keyboards/aplx6/README.md

* Update keyboards/aplx6/README.md

* Update keyboards/aplx6/rules.mk

* Update keyboards/aplx6/rules.mk

* Update keyboards/aplx6/README.md

* Update keyboards/aplx6/README.md

* Update keyboards/aplx6/README.md

* pins update

* update

* update pins

* Update keyboards/aplx6/README.md

* Update keyboards/aplx6/README.md

* initial commit

* Update aplx2.h

* Update keyboards/aplx2/README.md

* Update keyboards/aplx6/README.md

* Update keyboards/aplx6/README.md

* Update keyboards/aplx2/README.md

* folder change

* Update keyboards/handwired/aplx2/README.md

* Update keyboards/handwired/aplx2/README.md

* latest suggestion

* Update keyboards/handwired/aplx2/README.md
turky pushed a commit to turky/qmk_firmware that referenced this pull request Jun 13, 2020
@Aplyard @turky
[Keyboard] Aplx2 osu! keyboard (qmk#8847)
a9fe4b1 
* Create test.txt

* aplx6

* Delete test.txt

* fff

* Delete ffff

* test compile

* Create README.md

* edited

* requests

* Update keyboards/aplx6/README.md

* Update keyboards/aplx6/README.md

* Update keyboards/aplx6/README.md

* Update keyboards/aplx6/README.md

* Update keyboards/aplx6/README.md

* Update keyboards/aplx6/README.md

* Update keyboards/aplx6/README.md

* Update keyboards/aplx6/rules.mk

* Update keyboards/aplx6/rules.mk

* Update keyboards/aplx6/README.md

* Update keyboards/aplx6/README.md

* Update keyboards/aplx6/README.md

* pins update

* update

* update pins

* Update keyboards/aplx6/README.md

* Update keyboards/aplx6/README.md

* initial commit

* Update aplx2.h

* Update keyboards/aplx2/README.md

* Update keyboards/aplx6/README.md

* Update keyboards/aplx6/README.md

* Update keyboards/aplx2/README.md

* folder change

* Update keyboards/handwired/aplx2/README.md

* Update keyboards/handwired/aplx2/README.md

* latest suggestion

* Update keyboards/handwired/aplx2/README.md
jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
@Aplyard @jakobaa
[Keyboard] Aplx2 osu! keyboard (qmk#8847)
0c111fa 
* Create test.txt

* aplx6

* Delete test.txt

* fff

* Delete ffff

* test compile

* Create README.md

* edited

* requests

* Update keyboards/aplx6/README.md

* Update keyboards/aplx6/README.md

* Update keyboards/aplx6/README.md

* Update keyboards/aplx6/README.md

* Update keyboards/aplx6/README.md

* Update keyboards/aplx6/README.md

* Update keyboards/aplx6/README.md

* Update keyboards/aplx6/rules.mk

* Update keyboards/aplx6/rules.mk

* Update keyboards/aplx6/README.md

* Update keyboards/aplx6/README.md

* Update keyboards/aplx6/README.md

* pins update

* update

* update pins

* Update keyboards/aplx6/README.md

* Update keyboards/aplx6/README.md

* initial commit

* Update aplx2.h

* Update keyboards/aplx2/README.md

* Update keyboards/aplx6/README.md

* Update keyboards/aplx6/README.md

* Update keyboards/aplx2/README.md

* folder change

* Update keyboards/handwired/aplx2/README.md

* Update keyboards/handwired/aplx2/README.md

* latest suggestion

* Update keyboards/handwired/aplx2/README.md
sjmacneil pushed a commit to sjmacneil/qmk_firmware that referenced this pull request Feb 19, 2021
@Aplyard @sjmacneil
[Keyboard] Aplx2 osu! keyboard (qmk#8847)
449d39c 
* Create test.txt

* aplx6

* Delete test.txt

* fff

* Delete ffff

* test compile

* Create README.md

* edited

* requests

* Update keyboards/aplx6/README.md

* Update keyboards/aplx6/README.md

* Update keyboards/aplx6/README.md

* Update keyboards/aplx6/README.md

* Update keyboards/aplx6/README.md

* Update keyboards/aplx6/README.md

* Update keyboards/aplx6/README.md

* Update keyboards/aplx6/rules.mk

* Update keyboards/aplx6/rules.mk

* Update keyboards/aplx6/README.md

* Update keyboards/aplx6/README.md

* Update keyboards/aplx6/README.md

* pins update

* update

* update pins

* Update keyboards/aplx6/README.md

* Update keyboards/aplx6/README.md

* initial commit

* Update aplx2.h

* Update keyboards/aplx2/README.md

* Update keyboards/aplx6/README.md

* Update keyboards/aplx6/README.md

* Update keyboards/aplx2/README.md

* folder change

* Update keyboards/handwired/aplx2/README.md

* Update keyboards/handwired/aplx2/README.md

* latest suggestion

* Update keyboards/handwired/aplx2/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noroadsleft noroadsleft noroadsleft approved these changes

@zvecr zvecr zvecr approved these changes

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna Awaiting requested review from drashna

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Aplyard @zvecr @noroadsleft @drashna @fauxpark